feature(utils): Rounds out updating configuration #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main function `update_config()` was already in place, this rounds it out by converting the values associated with the keys `base_dir` and `output_dir` to be objects of type `Path` so they are easy to use in subsequent processing. Will have to ensure in each processor function that after the configuration is loaded a call is made to `utils.update_config()` so that values get updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main function
update_config()was already in place, this rounds it out by converting the values associated with thekeys
base_dirandoutput_dirto be objects of typePathso they are easy to use in subsequent processing.Will have to ensure in each processor function that after the configuration is loaded a call is made to
utils.update_config()so that values get updated.