build: minimal set of dependencies #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runs the code on the minimal reproducible example that @jjriley1 is developing on [jjriley1/slam_3UIs:jjriley1/1-tidy-up](https://github.com/jjriley1/slam_3UIs/tree/jjriley1/1-tidy-up). Installing in a clean virtual environment the script at least runs against commit `0d00ec98253919a3cf5a4b34e5e6bde771acfb1e` (and `fb93e864390e2a3517ffb7ee2bed5ab2cc923a9c`) although currently because of hard coded files in `pipeline_slam_3UIs/pipeline.yaml` no processing is undertaken with the sample files that have been provided. I expect the dependencies to grow as we add more functionality and have deliberately left `pandas`, `numpy` and `matplotlib` as dependencies as they will be used to do the legwork that the various R scripts currently do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
These packages allow running the code on the minimal reproducible example that @jjriley1 is developing on
jjriley1/slam_3UIs:jjriley1/1-tidy-up.
Installing in a clean virtual environment the script at least runs against commit
0d00ec98253919a3cf5a4b34e5e6bde771acfb1e(andfb93e864390e2a3517ffb7ee2bed5ab2cc923a9c) although currently becauseof hard coded files in
pipeline_slam_3UIs/pipeline.yamlno processing is undertaken with the sample files that havebeen provided.
I expect the dependencies to grow as we add more functionality and have deliberately left
pandas,numpyandmatplotlibas dependencies as they will be used to do the legwork that the various R scripts currently do.