fix: handle api error gracefully

sudoblockio · Mar 23, 2024 · 21b3ba1 · 21b3ba1
1 parent 9e249b9
commit 21b3ba1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/api/rest/addresses.go b/src/api/rest/addresses.go
@@ -156,16 +156,17 @@ func handlerGetAddressDetails(c *fiber.Ctx) error {
 	params := new(AddressesQuery)
 	if err := c.QueryParser(params); err != nil {
 		zap.S().Warnf("Addresses Get Handler ERROR: %s", err.Error())
-
 		c.Status(422)
 		return c.SendString(`{"error": "could not parse query parameters"}`)
 	}
 
 	// Get Addresses
-	address, err := crud.GetAddressCrud().SelectOne(
-		addressString,
-	)
+	address, err := crud.GetAddressCrud().SelectOne(addressString)
 	if err != nil {
+		if err == crud.ErrRecordNotFound {
+			c.Status(404)
+			return c.SendString(`{"error": "address not found"}`)
+		}
 		c.Status(500)
 		zap.S().Warn(
 			"Endpoint=handlerGetAddressDetails",
@@ -179,7 +180,6 @@ func handlerGetAddressDetails(c *fiber.Ctx) error {
 	if err != nil {
 		return c.SendString(`{"error": "parsing error"}`)
 	}
-
 	return c.SendString(string(body))
 }
 

diff --git a/src/crud/utils.go b/src/crud/utils.go
@@ -1,6 +1,11 @@
 package crud
 
-import "reflect"
+import (
+	"errors"
+	"reflect"
+)
+
+var ErrRecordNotFound = errors.New("record not found")
 
 func extractFilledFieldsFromModel(modelValueOf reflect.Value, modelTypeOf reflect.Type) map[string]interface{} {