fix: improve the error logging statements

src/api/rest/addresses.go

@@ -2,6 +2,8 @@ package rest
 
 import (
 	"encoding/json"
+	"errors"
+	"gorm.io/gorm"
 	"strconv"
 
 	fiber "github.com/gofiber/fiber/v2"
@@ -163,7 +165,7 @@ func handlerGetAddressDetails(c *fiber.Ctx) error {
 	// Get Addresses
 	address, err := crud.GetAddressCrud().SelectOne(addressString)
 	if err != nil {
-		if err == crud.ErrRecordNotFound {
+		if errors.Is(err, gorm.ErrRecordNotFound) {
 			c.Status(404)
 			return c.SendString(`{"error": "address not found"}`)
 		}
@@ -337,7 +339,7 @@ func handlerGetTokenAddresses(c *fiber.Ctx) error {
 	addressString := c.Params("address")
 
 	// Get TokenAddresses
-	tokenAddresss, err := crud.GetTokenAddressCrud().SelectManyByAddress(addressString)
+	tokenAddress, err := crud.GetTokenAddressCrud().SelectManyByAddress(addressString)
 	if err != nil {
 		c.Status(500)
 		zap.S().Warn(
@@ -347,14 +349,14 @@ func handlerGetTokenAddresses(c *fiber.Ctx) error {
 		return c.SendString(`{"error": "could not retrieve addresses"}`)
 	}
 
-	if len(*tokenAddresss) == 0 {
+	if len(*tokenAddress) == 0 {
 		// No Content
 		c.Status(204)
 	}
 
 	// []models.TokenAddress -> []string
 	var tokenContractAddresses []string
-	for _, a := range *tokenAddresss {
+	for _, a := range *tokenAddress {
 		tokenContractAddresses = append(tokenContractAddresses, a.TokenContractAddress)
 	}
 

src/api/rest/blocks.go

@@ -2,6 +2,8 @@ package rest
 
 import (
 	"encoding/json"
+	"errors"
+	"gorm.io/gorm"
 	"strconv"
 
 	fiber "github.com/gofiber/fiber/v2"
@@ -152,10 +154,13 @@ func handlerGetBlockDetails(c *fiber.Ctx) error {
 
 	block, err := crud.GetBlockCrud().SelectOne(uint32(number))
 	if err != nil {
-		c.Status(404)
-		return c.SendString(`{"error": "no block found"}`)
+		if errors.Is(err, gorm.ErrRecordNotFound) {
+			c.Status(404)
+			return c.SendString(`{"error": "no block found"}`)
+		}
+		c.Status(500)
+		return c.SendString(`{"error": "could not retrieve block"}`)
 	}
-
 	body, _ := json.Marshal(&block)
 	return c.SendString(string(body))
 }
@@ -188,8 +193,12 @@ func handlerGetBlockTimestampDetails(c *fiber.Ctx) error {
 
 	block, err := crud.GetBlockCrud().SelectOneByTimestamp(uint64(timestamp))
 	if err != nil {
-		c.Status(404)
-		return c.SendString(`{"error": "no block found"}`)
+		if errors.Is(err, gorm.ErrRecordNotFound) {
+			c.Status(404)
+			return c.SendString(`{"error": "no block found"}`)
+		}
+		c.Status(500)
+		return c.SendString(`{"error": "could not retrieve block"}`)
 	}
 
 	body, _ := json.Marshal(&block)

src/api/rest/logs.go

@@ -2,6 +2,7 @@ package rest
 
 import (
 	"encoding/json"
+	"errors"
 	"gorm.io/gorm"
 	"strconv"
 
@@ -91,7 +92,7 @@ func handlerGetLogs(c *fiber.Ctx) error {
 		params.Method,
 	)
 	if err != nil {
-		if err == gorm.ErrRecordNotFound {
+		if errors.Is(err, gorm.ErrRecordNotFound) {
 			c.Status(404)
 			return c.SendString(`{"error": "logs not found"}`)
 		}

src/api/rest/transactions.go

@@ -2,10 +2,12 @@ package rest
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	fiber "github.com/gofiber/fiber/v2"
 	"github.com/sudoblockio/icon-go-api/models"
 	"go.uber.org/zap"
+	"gorm.io/gorm"
 	"strconv"
 	"sync"
 
@@ -231,10 +233,13 @@ func handlerGetTransaction(c *fiber.Ctx) error {
 
 	transaction, err := crud.GetTransactionCrud().SelectOne(hash, -1)
 	if err != nil {
-		c.Status(404)
-
+		if errors.Is(err, gorm.ErrRecordNotFound) {
+			c.Status(404)
+			return c.SendString(`{"error": "transaction not found"}`)
+		}
+		c.Status(500)
 		zap.S().Warn(err.Error())
-		return c.SendString(`{"error": "no transaction found"}`)
+		return c.SendString(`{"error": "could not retrieve transaction"}`)
 	}
 
 	body, _ := json.Marshal(&transaction)

src/crud/utils.go

@@ -1,12 +1,9 @@
 package crud
 
 import (
-	"errors"
 	"reflect"
 )
 
-var ErrRecordNotFound = errors.New("record not found")
-
 func extractFilledFieldsFromModel(modelValueOf reflect.Value, modelTypeOf reflect.Type) map[string]interface{} {
 
 	fields := map[string]interface{}{}