FIX: Prompt Command Detection (Also Code Style from PR 16) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the arguments passed to Shell Mommy are identical to the recommended usage of export PROMPT_COMMAND="mommy \\$\\(exit \$?\\); $PROMPT_COMMAND" Then we know that Shell Mommy is 99% most likely being run via PROMPT_COMMAND and we don't need eval in this instance.
Pull Request sudofox#16 introduced if [[ $rc -eq 130 ]] then But this is less legible and goes against the prior established style of If Statements in Shell Mommy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I've reasonably solved the the TODO:
By checking if our argument matches what the README suggests for
$PROMPT_COMMAND's value, Shell Mommy can be confident that she is in fact, in all likelyhood, running from$PROMPT_COMMAND.There isn't much of a reason to pass such a strange (and quite unpleasant to properly escape) argument to her otherwise x3
Merging #16 also introduced a strangely formatted If statement that both significantly goes against the current style, but also is (in my opinion, but it is really subjective) harder to read.
So this also brings that If Statement more in-line with the rest of Shell Mommy's If Statements