Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other Redmine plugins compatibility #37

Merged
merged 1 commit into from
May 22, 2021
Merged

Conversation

yzzy
Copy link
Contributor

@yzzy yzzy commented May 12, 2021

To those who have lost this plugin settings tab (#26, #32, #34)

  • Redmine is patching some other way, so plugin should not conflict with other plugins redefining Settings tabs set (including redmine_dmsf)
  • Manage hook permission moved from Project section to its own Webhooks
  • Webhook settings tab won't be shown at all if current user has no manage hook permission

@suer suer merged commit 82f59b5 into suer:master May 22, 2021
@suer
Copy link
Owner

suer commented May 22, 2021

thanks!

@yzzy yzzy deleted the dmsf-compatibility branch April 1, 2022 11:05
@serpi90
Copy link
Contributor

serpi90 commented Jun 2, 2022

I had to enable the webhook module in 27 projects because of this change, luckily i was able to do it via a quick & dirty sql script.

A notice or migration script that enables it for all projects may be necessary. Not for fresh installs, but for updates.

@yzzy
Copy link
Contributor Author

yzzy commented Jun 3, 2022

You are right, backward compatibility is often underestimated.

@serpi90
Copy link
Contributor

serpi90 commented Jun 4, 2022

Something like this should work, at least in postgres:

insert into enabled_modules (project_id, "name") 
select project_id, 'webhooks'
from webhooks
where project_id != 0
group by project_id
order by project_id

Don't know how to write it as a rails migration script.

Also, as far as I understand, webhooks still work if the module is disabled. I'm not sure if that is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants