✨Public and restricted doc editable #357

AntoLC · 2024-10-18T15:13:15Z

Purpose

We increased the visibility options for docs:

public
restricted
authenticated

We also have 2 editability options:

readonly
editable

The editability options are only available for public and authenticated docs.

Proposal

♻️(frontend) minor components update
✨(frontend) increase doc visibility options
tests

Demo

scrnli_VZHQd70DS9qxw9.webm

PanchoutNathan

✅ Nice work ! This is a cool feature !

Small observations :

there is a slight shift in height when the restrictions are displayed or not.
I might have liked to know that we are on the document as an unconnected guest. Maybe not, I thought about it quickly so I'm sharing it

PanchoutNathan · 2024-10-22T12:06:09Z

src/frontend/apps/impress/src/features/docs/doc-management/components/ModalShare.tsx

+                      navigator.clipboard
+                        .writeText(window.location.href)
+                        .then(() => {
+                          toast(t('Link Copied !'), VariantType.SUCCESS, {
+                            duration: 3000,
+                          });
+                        })
+                        .catch(() => {
+                          toast(t('Failed to copy link'), VariantType.ERROR, {
+                            duration: 3000,
+                          });
+                        });


I think it would be good to turn it into a hook, because I think we could need it in the home page list via the "..." for example. Or even an invitation link for new members instead of inviting one by one.

When we will need it somewhere else, yes you are right, but we use it only here for the moment, let's keep it scoped until we need it outside.

PanchoutNathan · 2024-10-22T12:09:26Z

src/frontend/apps/impress/src/features/docs/doc-management/types.tsx

+export enum LinkRole {
+  READER = 'reader',
+  EDITOR = 'editor',
+}
+
 export type Base64 = string;

 export interface Doc {
  id: string;
  title: string;
  content: Base64;
  link_reach: LinkReach;
-  link_role: 'reader' | 'editor';
+  link_role: LinkRole;
  accesses: Access[];
  created_at: string;
  updated_at: string;


I think this type is not only related to this feature, but can be used everywhere. I moved this file to the root of the feature/docs folder. But maybe in another PR? and maybe. And maybe you don't agree with that

The feature doc-management actually is for related things about doc that can be used in others features.

PanchoutNathan · 2024-10-22T12:26:29Z

src/frontend/apps/impress/src/features/docs/doc-management/components/DocVisibility.tsx

+                {
+                  label: t('Read only'),
+                  value: LinkRole.READER,
+                },
+                {
+                  label: t('Can read and edit'),
+                  value: LinkRole.EDITOR,
+                },
+              ].map((radio) => (


Maybe create a constant above?

PanchoutNathan · 2024-10-22T12:43:27Z

src/frontend/apps/impress/src/features/docs/doc-management/components/DocVisibility.tsx

+        {(doc.link_reach === LinkReach.AUTHENTICATED ||
+          doc.link_reach === LinkReach.PUBLIC) && (


what do you think of creating a constant with explicit naming? like for example :

const showRestrictedOptions = doc.link_reach === LinkReach.AUTHENTICATED || doc.link_reach === LinkReach.PUBLIC

or

const showRestrictedOptions = [LinkReach.AUTHENTICATED, LinkReach.PUBLIC].includes(doc.link_reach);

PanchoutNathan · 2024-10-22T12:55:03Z

src/frontend/apps/e2e/__tests__/app-impress/doc-member-list.spec.ts

@@ -164,14 +164,22 @@ test.describe('Document list members', () => {
    const shareModal = page.getByLabel('Share modal');


Add tests to know if restrictions should be shown or not based on visibility

AntoLC

✅ Nice work ! This is a cool feature

Yes this feature is waited since the beginning of the project. ^^

AntoLC · 2024-10-22T13:42:10Z

src/frontend/apps/impress/src/features/docs/doc-management/components/ModalShare.tsx

+                      navigator.clipboard
+                        .writeText(window.location.href)
+                        .then(() => {
+                          toast(t('Link Copied !'), VariantType.SUCCESS, {
+                            duration: 3000,
+                          });
+                        })
+                        .catch(() => {
+                          toast(t('Failed to copy link'), VariantType.ERROR, {
+                            duration: 3000,
+                          });
+                        });


When we will need it somewhere else, yes you are right, but we use it only here for the moment, let's keep it scoped until we need it outside.

AntoLC · 2024-10-22T13:48:37Z

src/frontend/apps/impress/src/features/docs/doc-management/types.tsx

+export enum LinkRole {
+  READER = 'reader',
+  EDITOR = 'editor',
+}
+
 export type Base64 = string;

 export interface Doc {
  id: string;
  title: string;
  content: Base64;
  link_reach: LinkReach;
-  link_role: 'reader' | 'editor';
+  link_role: LinkRole;
  accesses: Access[];
  created_at: string;
  updated_at: string;


The feature doc-management actually is for related things about doc that can be used in others features.

- change flex property of Box component - Forward the ref of Text component - globalize tooltip padding

We now have 3 visibility options for docs: - public - restricted - authenticated We also have 2 editability options: - readonly - editable The editability options are only available for public and authenticated docs.

AntoLC added frontend feature labels Oct 18, 2024

AntoLC self-assigned this Oct 18, 2024

This was linked to issues Oct 18, 2024

Add edit roles "anyone with the link" #238

Closed

✨Link doc #153

Closed

AntoLC force-pushed the feature/doc-public-editable branch 4 times, most recently from 6ed9f15 to 00e7b27 Compare October 22, 2024 10:00

AntoLC changed the title ~~✨Public doc editable~~ ✨Public and restricted doc editable Oct 22, 2024

AntoLC force-pushed the feature/doc-public-editable branch from 00e7b27 to 1d1832b Compare October 22, 2024 11:29

AntoLC marked this pull request as ready for review October 22, 2024 11:43

AntoLC requested a review from PanchoutNathan October 22, 2024 11:43

PanchoutNathan reviewed Oct 22, 2024

View reviewed changes

AntoLC force-pushed the feature/doc-public-editable branch from 562cc79 to 2721c4e Compare October 22, 2024 14:12

AntoLC commented Oct 22, 2024

View reviewed changes

AntoLC requested a review from PanchoutNathan October 22, 2024 14:15

PanchoutNathan approved these changes Oct 23, 2024

View reviewed changes

AntoLC added 2 commits October 23, 2024 11:11

♻️(frontend) minor components update

4754720

- change flex property of Box component - Forward the ref of Text component - globalize tooltip padding

✨(frontend) increase doc visibility options

9c901b5

We now have 3 visibility options for docs: - public - restricted - authenticated We also have 2 editability options: - readonly - editable The editability options are only available for public and authenticated docs.

AntoLC force-pushed the feature/doc-public-editable branch from 2721c4e to 9c901b5 Compare October 23, 2024 09:11

AntoLC enabled auto-merge (rebase) October 23, 2024 09:11

AntoLC merged commit ff364f8 into main Oct 23, 2024
13 of 16 checks passed

AntoLC deleted the feature/doc-public-editable branch October 23, 2024 09:20

AntoLC mentioned this pull request Oct 24, 2024

🔖(minor) release 1.7.0 #382

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨Public and restricted doc editable #357

✨Public and restricted doc editable #357

AntoLC commented Oct 18, 2024 •

edited

Loading

PanchoutNathan left a comment

PanchoutNathan Oct 22, 2024

AntoLC Oct 22, 2024

PanchoutNathan Oct 22, 2024

AntoLC Oct 22, 2024

PanchoutNathan Oct 22, 2024

PanchoutNathan Oct 22, 2024

PanchoutNathan Oct 22, 2024

AntoLC left a comment

AntoLC Oct 22, 2024

AntoLC Oct 22, 2024

		{(doc.link_reach === LinkReach.AUTHENTICATED \|\|
		doc.link_reach === LinkReach.PUBLIC) && (

		@@ -164,14 +164,22 @@ test.describe('Document list members', () => {
		const shareModal = page.getByLabel('Share modal');

✨Public and restricted doc editable #357

✨Public and restricted doc editable #357

Conversation

AntoLC commented Oct 18, 2024 • edited Loading

Purpose

Proposal

Demo

PanchoutNathan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AntoLC left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AntoLC commented Oct 18, 2024 •

edited

Loading