♻️(backend) rename required claims to essential claims as per spec #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaccoud
added
enhancement
sampaccoud
force-pushed
the
rename-required-claims-to-essential
branch
from
99bf441 to
c56ffce
Compare
sampaccoud
force-pushed
the
rename-required-claims-to-essential
branch
from
c56ffce to
fb22ba4
Compare
AntoLC
approved these changes
Jan 2, 2025
sampaccoud
force-pushed
the
rename-required-claims-to-essential
branch
2 times, most recently
from
6f82122 to
e087cf7
Compare
lebaudantoine
approved these changes
Jan 3, 2025
sampaccoud
force-pushed
the
rename-required-claims-to-essential
branch
from
f06ce87 to
0effe82
Compare
It was pointed by @lebaudantoine that the OIDC specification uses the term "essential claims" for what we called required claims. Further more, the Mozilla OIDC library that we use, validates claims in a method called "verify_claims". Let's override this method.
We had doubts that the user was correctly updated in the case where its identity was matched on the email and not on the sub. I added a test and confirmed that it was working correctly. I still modified the backend to update the user based on its "id" instead of its "sub" because it was confusing, but both actually work the same.
sampaccoud
force-pushed
the
rename-required-claims-to-essential
branch
from
0effe82 to
2b2daf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It was pointed by @lebaudantoine that the OIDC specification uses the term "essential claims" for what we called "required claims".
Further more, the Mozilla OIDC library that we use, validates claims in a method called "verify_claims".
Let's do it in the same method by overriding it.
Proposal