🏷️(backend) add content-type to uploaded files #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
issue/add-content-type-uploaded-files
branch
3 times, most recently
from
1fcc576 to
e39fab4
Compare
sampaccoud
reviewed
Jan 14, 2025
sampaccoud
reviewed
Jan 14, 2025
AntoLC
force-pushed
the
issue/add-content-type-uploaded-files
branch
6 times, most recently
from
1fa20e6 to
012af6f
Compare
lunika
reviewed
Jan 16, 2025
sampaccoud
approved these changes
Jan 20, 2025
AntoLC
force-pushed
the
issue/add-content-type-uploaded-files
branch
2 times, most recently
from
45b9fbc to
8db58c7
Compare
All the uploaded files had the content-type set to `application/octet-stream`. It create issues when the file is downloaded from the frontend because the browser doesn't know how to handle the file. We now determine the content-type of the file and set it to the file object.
Add django-test-migrations to the project. It is a tool that helps to test Django migrations.
The uploaded files in the system are missing the content-type. We add a migration to update the content-type of the existing uploaded files.
AntoLC
force-pushed
the
issue/add-content-type-uploaded-files
branch
from
8db58c7 to
5711bf5
Compare
lunika
reviewed
Jan 21, 2025
| from django.db import migrations | ||
| from django.core.files.storage import default_storage | ||
|
|
||
| def fix_attachments_content_type(apps, schema_editor): |
There was a problem hiding this comment.
All of this should be made in a management command. It is a not related to a database modification and tests should be added IMO
There was a problem hiding this comment.
And so we have to create a job in the helm chart to run this kind of management command. I will made it in this branch if you are ok
There was a problem hiding this comment.
Yes feel free to do it. 🙏
For a specific deployment we may need to run a specific management command, like the one added previously updating all files content-type. A template is added responsible to manage this case. The job will be created only if the backend.job.command is set.
|
@AntoLC I updated the PR accordingly with my last suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
All the uploaded files had the content-type set to
application/octet-stream. It create issues when the file is downloaded from the frontend because the browser doesn't know how to handle the file.Proposal
We improved the mimetype database and we now determine the content-type of the file and set it to the file object.