Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(domains) send email when domain status changes #668

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

sdemagny
Copy link
Contributor

@sdemagny sdemagny commented Jan 27, 2025

During the scheduled task to check domains, send an email notification to domain support if a status has changed.
Capture d’écran 2025-03-24 à 13 03 26
Capture d’écran 2025-03-24 à 13 03 20
Capture d’écran 2025-03-24 à 13 03 14

@sdemagny sdemagny self-assigned this Feb 13, 2025
@sdemagny sdemagny force-pushed the sdem/notify_owner_admin_domain branch 3 times, most recently from 2fb1c98 to c7dba25 Compare March 21, 2025 21:50
@sdemagny sdemagny marked this pull request as ready for review March 21, 2025 21:59
@sdemagny sdemagny force-pushed the sdem/notify_owner_admin_domain branch 3 times, most recently from 9cbdb2b to a66281d Compare March 21, 2025 22:25
@sdemagny sdemagny requested a review from qbey March 24, 2025 11:15
For now, to avoid overloading dimail, we have defined a
time interval between each check request to dimail.
This interval should be configurable for testing and
different environments.
@sdemagny sdemagny force-pushed the sdem/notify_owner_admin_domain branch from a66281d to 4df5ef5 Compare March 24, 2025 12:07

<mj-body mj-class="bg--blue-100">
<mj-wrapper css-class="wrapper" padding="10px">
<mj-section>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be also moved into a dedicated mj-include?

@sdemagny sdemagny force-pushed the sdem/notify_owner_admin_domain branch from 4df5ef5 to 4891d1c Compare March 24, 2025 14:32
@sdemagny sdemagny requested a review from qbey March 24, 2025 14:36
@sdemagny sdemagny force-pushed the sdem/notify_owner_admin_domain branch from 4891d1c to 544b25b Compare March 24, 2025 14:37
@sdemagny sdemagny enabled auto-merge (rebase) March 24, 2025 15:13
@sdemagny sdemagny disabled auto-merge March 24, 2025 16:16
During the scheduled task to check domains,
send an email notification to domain support if a
status has changed.
@sdemagny sdemagny force-pushed the sdem/notify_owner_admin_domain branch from 544b25b to 10e526a Compare March 24, 2025 20:18
@sdemagny sdemagny enabled auto-merge (rebase) March 24, 2025 21:21
@sdemagny sdemagny merged commit 5178e46 into main Mar 25, 2025
17 of 19 checks passed
@sdemagny sdemagny deleted the sdem/notify_owner_admin_domain branch March 25, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants