Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš‘οΈ(teams) do not display add button when disallowed #676

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

qbey
Copy link
Member

@qbey qbey commented Jan 30, 2025

Purpose

The frontend should not display "add team" actions when the user has not the ability.
When we don't allow the user to see the team creation button, we also want to disable the corresponding API.

Proposal

  • hide team creation button according to user abilities
  • check user abilities on team creation endpoint

@qbey qbey self-assigned this Jan 30, 2025
@qbey qbey requested a review from sdemagny January 30, 2025 15:47
@qbey qbey added the bug Something isn't working label Jan 30, 2025
@qbey qbey force-pushed the qbey/fix-team-creation-ability branch 2 times, most recently from 4953c0e to c0f1dd7 Compare January 31, 2025 10:43
Copy link
Contributor

@sdemagny sdemagny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste dans le message de commit remets le "s" de display stp -> πŸš‘οΈ(teams) do not diplay add button when disallowed

qbey added 2 commits February 4, 2025 15:09
The frontend should not display "add team" actions when the
user has not the ability.
When we don't allow the user to see the team creation button,
we also want to disable the corresponding API.
@qbey qbey force-pushed the qbey/fix-team-creation-ability branch from c0f1dd7 to ef09b4a Compare February 4, 2025 14:09
@qbey qbey changed the title πŸš‘οΈ(teams) do not diplay add button when disallowed πŸš‘οΈ(teams) do not display add button when disallowed Feb 4, 2025
@qbey qbey enabled auto-merge (rebase) February 4, 2025 14:10
@qbey qbey merged commit b4a8773 into main Feb 4, 2025
19 checks passed
@qbey qbey deleted the qbey/fix-team-creation-ability branch February 4, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants