🔒️(organization) the first user is not admin #776
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first user of a organization is probably not an admin. This was implemented for first tests but for now it's more a security issue than something helpful. FIXES #775
qbey
force-pushed
the
qbey/remove-first-org-user-is-admin
branch
from
2a4ca1b to
1462dae
Compare
sdemagny
approved these changes
Mar 7, 2025
Morendil
requested changes
Mar 10, 2025
|
@Morendil Ok, stand-by on this, but the current behavior is bad. This must be fixed soon. |
|
@qbey Yes, I have a fix in mind - change the plugin contract to "ask" whether to grant admin access instead of notifying of a grant (after the fact). This should let us remove the grant in the general case but preserve the current behaviour for communes for the time being. I need a few days to get around to working out the details though… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The first user of a organization is probably not an admin. This was implemented for first tests but for now it's more a security issue than something helpful.
FIXES #775
Proposal