🎨(front) ui v2 - mails domains layout #818
Open
+3,062
−2,359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header + left panel
style grid components
test e2e + linter + clean
Morendil
reviewed
Mar 17, 2025
| }) => { | ||
| await page.goto('/'); | ||
| await keyCloakSignIn(page, browserName, 'team-member'); | ||
| // test('it checks that the user abilities display teams', async ({ |
There was a problem hiding this comment.
Don't comment out, just delete. :)
Morendil
reviewed
Mar 17, 2025
| @@ -137,7 +139,7 @@ test.describe('Mail domain', () => { | |||
| 'It seems that the page you are looking for does not exist or cannot be displayed correctly.', | |||
| ), | |||
| ).toBeVisible({ | |||
| timeout: 15000, | |||
| timeout: 700000, | |||
There was a problem hiding this comment.
I'm really worried about the consequences of allowing a worst-case duration of 15 minutes for our CI… I would either delete the test, or (preferably) fix the underlying problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui V2 - global layout + table