Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝(release) update release.md #829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mjeammet
Copy link
Member

@mjeammet mjeammet commented Mar 18, 2025

Purpose

Update documentation on release process.

@mjeammet mjeammet self-assigned this Mar 18, 2025

7. The release is now done!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En fait le 3, 4, 5, 6, 7 (ligne 32 à 46) devraient etre la suite du "4. Commit your changes with the following format:". Il a eu un foirage :D
Il s'agit de la description de ce que fait le script de release.
Il y a besoin de décrire en détails ce qu'il fait. Le déploiement en preprod se fait via le script "make release" pas à la main. Donc faudrait laisser les explications ici.
Et le "3. Open a pull request ask you to wait for an approval from your peers and merge it." devrait être un truc du genre "Create a new and ask you to create a PR..."

Copy link
Member Author

@mjeammet mjeammet Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes merci pour le rappel, j'avais oublié que le script ouvrait automatiquement une branche là-bas.
Ca donne un peu envie d'ouvrir aussi la PR de prod à ce moment-là aussi, non ? Elle peut rester une semaine.

Peut-être même qu'on pourrait la mettre en automerge et ce serait JB qui, une fois sa recette faite, met le approve et déclencherait la prod. Qu'est-ce que tu en dis ?

@mjeammet mjeammet force-pushed the mpj/update-release-md branch 5 times, most recently from 7efccb5 to 5ff5d28 Compare March 19, 2025 10:09
Update documentation on release
@mjeammet mjeammet force-pushed the mpj/update-release-md branch from 5ff5d28 to 118932c Compare March 19, 2025 10:12
@mjeammet mjeammet requested a review from sdemagny March 25, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants