Use a labeled <aside> for tools sidebar #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link to the blacklight change? |
This mirrors template changes in Blacklight 8.8 that convert the sidebar from a <section> into an <aside> with label. Ref projectblacklight/blacklight@2fa70cf Closes #1437
thatbudakguy
force-pushed
the
labeled-tools-aside
branch
from
d6a74e9 to
38b4ac2
Compare
|
Updated to add it to the comment and commit message; good call |
jcoyne
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors template changes in Blacklight 8.8 that convert the
sidebar from a
<section>into an<aside>with label.Ref projectblacklight/blacklight@2fa70cf
Closes #1437