Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hide-title for component window viewers #2430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable hide-title for component window viewers #2430

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Feb 11, 2025 •
edited
Loading

This worked on the legacy viewers and Mirador, so this PR brings it to the new viewers.

@jcoyne jcoyne force-pushed the hide-title branch 3 times, most recently from c04d3cf to 62e6383 Compare February 11, 2025 17:32
dnoneill
dnoneill requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@dnoneill dnoneill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it should work
Screenshot 2025-02-13 at 6 02 08 PM

How it's working in new viewers
Screenshot 2025-02-13 at 6 03 17 PM

The fullscreen/etc icons are not being right aligned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnoneill dnoneill dnoneill requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcoyne @dnoneill