Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the file label font size smaller #2439

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Set the file label font size smaller #2439

merged 1 commit into from
Feb 13, 2025

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Feb 11, 2025

Fixes #2422

@dnoneill
Copy link
Contributor

@jcoyne This isn't doing anything because of this line:

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 12, 2025

This sets/overrides this variable.

@dnoneill
Copy link
Contributor

dnoneill commented Feb 12, 2025

@jcoyne It doesn't. I have checked locally, everything is still 14px.

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 12, 2025

Here's what I see:
File name
Screenshot 2025-02-12 at 3 43 06 PM

description:
Screenshot 2025-02-12 at 3 42 09 PM

@dnoneill
Copy link
Contributor

dnoneill commented Feb 12, 2025

Yes. But that is not applying. If you look at the computed, it is 14px.
Screenshot 2025-02-12 at 5 03 00 PM

Also the text is the same size. This is what it is should look like. The line I pointed you to is overriding that --font-size-base, I think? I think it needs digging but right now the computed is showing the text size is 14px.
Screenshot 2025-02-12 at 5 07 03 PM

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 12, 2025

Yeah, I'm looking into that. The tools have lead me astray.

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 12, 2025

Okay, I gave up and just set it explicitly.

@dnoneill
Copy link
Contributor

@jcoyne This looks good on the subtitle/file level but in hierarchies the folders are 14px still. Can we fix that as well?
Screenshot 2025-02-13 at 10 41 21 AM

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 13, 2025

Sorry, the original ticket said "File name" so I wasn't sure you wanted this on File and directory names.

@dnoneill
Copy link
Contributor

Yeah I didn't realize until I was reviewing the PR, apologies.

@dnoneill dnoneill merged commit 8ff6c9f into main Feb 13, 2025
2 checks passed
@dnoneill dnoneill deleted the label-font-size branch February 13, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

font-size for file names
2 participants