WIP: Added social-media user-provider #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
feature/some-login
branch
3 times, most recently
from
080fb26
to
29ad156
Compare
| $user->setEnabled(true); | ||
| $user->setLocale('de'); // FIXME locale | ||
|
|
||
| $this->em->persist($contact); |
There was a problem hiding this comment.
Should implement this instead: https://github.com/sulu/SuluCommunityBundle/blob/develop/Controller/RegistrationController.php#L50-L68
| $contact->setLastName($response->getLastName()); | ||
| $user->setContact($contact); | ||
|
|
||
| $user->setUsername($this->generateRandomUsername($username, $service)); |
There was a problem hiding this comment.
could be generated from first part of the email address + uniquepostfix?
alexander-schranz
force-pushed
the
feature/some-login
branch
from
29ad156
to
a35146e
Compare
alexander-schranz
force-pushed
the
feature/some-login
branch
from
a35146e
to
a38e2d8
Compare
wachterjohannes
force-pushed
the
feature/some-login
branch
from
3ece27b
to
be51861
Compare
…into feature/some-login
wachterjohannes
force-pushed
the
feature/some-login
branch
from
c89e97d
to
455ef59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR integrates the
HWIOAuthBundleto allow social-media logins via facebook, google and co.To Do