Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the image actually exists in the ImageMediaAdapter #130

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Check if the image actually exists in the ImageMediaAdapter #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Adapter/ImageMediaAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,14 @@ private function updateMedia(MediaInterface $media, UploadedFile $uploadedFile,
$latestFileVersion = $existingFile->getLatestFileVersion();

if ($latestFileVersion && $latestFileVersion->getSize() === $uploadedFile->getSize()) {
// same image, not necessary to update anything
return $media;
try {
$this->storage->load($latestFileVersion->getStorageOptions());

// same image, not necessary to update anything
return $media;
} catch (\Exception $e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prokyonn is there a specific exception class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the LocalStorage it's just an ErrorException, but I don't know what exception other adapters throw

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then its ok

// file not found, continue
}
}
}

Expand Down