Add lint task for translations #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -164,6 +166,10 @@ | |||
| "lint-php-cs": "@php vendor/bin/php-cs-fixer fix --verbose --diff --dry-run", | |||
| "lint-composer": "@composer validate --no-check-publish --strict", | |||
| "lint-twig": "@php bin/console lint:twig templates/", | |||
| "lint-xliff": "@php bin/console lint:xliff translations/", | |||
| "lint-translations": [ | |||
| "@php bin/console debug:translation en --only-missing" | |||
There was a problem hiding this comment.
Additonal languages a project can add itself via:
- "@php bin/console debug:translation en --only-missing"
+ "@php bin/console debug:translation en --only-missing",
+ "@php bin/console debug:translation de --only-missing"In some cases it may be best to translate all via:
- "@php bin/console debug:translation en --only-missing",
+ "@php bin/console debug:translation --all en --only-missing",But specially if more bundles are added I want may only validate my own translations and not admin bundles.
| @@ -164,6 +166,10 @@ | |||
| "lint-php-cs": "@php vendor/bin/php-cs-fixer fix --verbose --diff --dry-run", | |||
| "lint-composer": "@composer validate --no-check-publish --strict", | |||
| "lint-twig": "@php bin/console lint:twig templates/", | |||
| "lint-xliff": "@php bin/console lint:xliff translations/", | |||
There was a problem hiding this comment.
This may make sense if a project use xliff files. still if project not using it it can remove it.
Prokyonn
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add lint task for translations.
Why?
Add a lint task to show which translation where missed when run
composer lint.Todo