Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ignore parameter #6

Merged
merged 2 commits into from
Sep 3, 2019
Merged

feat: add ignore parameter #6

merged 2 commits into from
Sep 3, 2019

Conversation

svewag
Copy link
Contributor

@svewag svewag commented Aug 29, 2019

in order to let Merlin ignore the specified paths, seperated by comma

feat: add ignore parameter
872feb6 
in order to let Merlin ignore the specified paths, seperated by comma
cilice
cilice approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@cilice cilice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall okay, but wouldn't it be easier to add a globby support instead of regex matches?

@svewag @cilice
Update README.md
777f0fb 
Co-Authored-By: Alexander Plavinski <[email protected]>
@svewag
Copy link
Contributor Author

svewag commented Sep 3, 2019

@cilice oh nice, didn't know it before. Thanks.

I opened a issue for that, #7

@svewag svewag merged commit 8524c40 into master Sep 3, 2019
@cilice cilice deleted the add-ignore-option branch September 3, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cilice cilice cilice approved these changes

@HerrBertling HerrBertling Awaiting requested review from HerrBertling

@ma-jahn ma-jahn Awaiting requested review from ma-jahn

@thmsnhl thmsnhl Awaiting requested review from thmsnhl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svewag @cilice