Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応理由
models/user.rb
が100行を越えようとしており、update_email_by(token)
メソッドでリファクタリングできそうだったので対応対応内容
new_email
からemail
にメールアドレスを移動・登録)を行う一連の処理をEmailUpdator
に切り出し、更新メソッドauthorize_new_email
のみに変更しました#authorize_new_email
のテストを追加しました補足
対応中に発見したバグがありました。別件で対応します。issue #20