new ljpack encode #109
Open
new ljpack encode #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms2008
reviewed
Apr 26, 2023
|
|
||
| function Response:ljpack(data) | ||
| self:set_header('Content-Type', 'application/ljpack') | ||
| self:__send(utils.ljpack_encode(data)) |
There was a problem hiding this comment.
I think it's enough to call the already existing self:_send directly.
Comment on lines
+119
to
+123
| function Response:__send(content) | ||
| ngx.status = self.http_status or 200 | ||
| ngx.print(content) | ||
| end | ||
|
|
| local smatch = string.match | ||
| local table_insert = table.insert | ||
| local json = require("cjson") | ||
| local st = require("string.buffer") |
There was a problem hiding this comment.
Since the new api string.buffer was introduced from OpenResty 1.12.4.1 onwards, it would be nice to have a fallback to be compatible with older versions of OpenResty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.