Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed relatives call to Wire.h and SPI.h #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

removed relatives call to Wire.h and SPI.h #13

wants to merge 6 commits into from

Conversation

PJCzx
Copy link

@PJCzx PJCzx commented Mar 27, 2020

As mentionned in #7 issue

../SPI/SPI.h
and
../Wire/Wire.h

are now repalced by

SPI.h
and
Wire.h

#7

@PJCzx
removed relatives call to Wire.h and SPI.h
b786e46 
As mentionned in sumotoy#7 issue

../SPI/SPI.h
and
../Wire/Wire.h

are now repalced by

SPI.h
and
Wire.h

sumotoy#7
This was referenced Mar 27, 2020
Open
Open
Open
PJCzx added 5 commits March 27, 2020 14:31
@PJCzx
Hard fix of
90055d3 
Not 100% sur of how dirty this fix is, but according to this (source)[https://forum.arduino.cc/index.php?topic=353602.0] I added the following in the `gpio_expander header`
```
#ifndef NOT_AN_INTERRUPT
#define NOT_AN_INTERRUPT -1
#endif
```
@PJCzx
Hard fix of
5e2ab10 
Not 100% sur of how dirty this fix is, but according to this (source)[https://forum.arduino.cc/index.php?topic=353602.0] I added the following in the `gpio_expander header`
```
#ifndef NOT_AN_INTERRUPT
#define NOT_AN_INTERRUPT -1
#endif
```
@PJCzx
Added MAXSPISPEED test if not defined
b4a2a0e
@PJCzx
Merge pull request #2 from PJCzx/MAXSPISPEED_FIX
6f7b8e9 
Added  MAXSPISPEED test if not defined
@PJCzx
Merge pull request #3 from PJCzx/INTERUPT_FIX
c714bb6 
Hard fix of
thijstriemstra
thijstriemstra approved these changes Aug 9, 2021
View reviewed changes
Copy link

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @sumotoy can this be merged?

@vladimir-aubrecht
Copy link

Hi @Ironicster / @sumotoy, do you think you could merge this PR? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PJCzx @vladimir-aubrecht @thijstriemstra