Reduce global css #2468
Merged
Reduce global css #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2468 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 210 210
Lines 12314 12314
Branches 1676 1676
=======================================
Hits 10894 10894
Misses 1370 1370
Partials 50 50
|
leonardodino
force-pushed
the
feat/reduce-global-css
branch
from
6b45a72
to
48ae27f
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed. |
sirineJ
force-pushed
the
feat/reduce-global-css
branch
from
48ae27f
to
d332c3b
Compare
this component is not exported nor ever used directly, so it doesn't need to hardcode the classes
connor-baer
force-pushed
the
feat/reduce-global-css
branch
from
d332c3b
to
945b96a
Compare
|
Size Change: +6 B (0%) Total Size: 639 kB
ℹ️ View Unchanged
|
connor-baer
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Until now, Circuit UI has been developed under the assumption that it is the only UI framework on the page. This isn’t always the case:
To better support these use cases, Circuit UI's styles should be locally scoped.
Approach and changes
strongandblockquoteelements to the Body componentDefinition of done