feat(DSYS-842): mark the tooltip & toggletip components as stable #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d25b344 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sirineJ
force-pushed
the
feat/DSYS-842/mark-tooltip-toggletip-stable
branch
from
e887f77
to
ec0fa45
Compare
|
Size Change: -62.8 kB (-8.96%) ✅ Total Size: 638 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2743 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 210 210
Lines 12314 12314
Branches 1676 1676
=======================================
Hits 10894 10894
Misses 1370 1370
Partials 50 50
|
sirineJ
force-pushed
the
feat/DSYS-842/mark-tooltip-toggletip-stable
branch
from
ec0fa45
to
d25b344
Compare
connor-baer
approved these changes
Oct 29, 2024
| @@ -42,7 +42,7 @@ Use the `onMonthChange` prop to lazy-load modifiers for the currently visible mo | |||
|
|
|||
| ```tsx | |||
| import { useState } from 'react'; | |||
| import { Calendar, type CalendarProps } from '@sumup-oss/circuit-ui/experimental'; | |||
| import { Calendar, type CalendarProps } from '@sumup-oss/circuit-ui'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-842
Purpose
The Tooltip and Toggletip components were introduced as a replacement for the old Tooltip component to better handle accessibility issues this component had. They had been marked as experimental since their release and has some positioning issues that have been fixed. Their API is stable and they are ready to be marked as stable.
Approach and changes
Definition of done