Added spacing adjustments to highlighting vertical text #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue pwmt#670
This pull request addresses an issue with the vertical text selection highlight where an extra character of vertical space appears at the top of the text, causing the highlight to be slightly misaligned. The text is also slightly shifted right.
Changes Made:
Adjusted the dimensions of the rectangles that envelop vertical text to eliminate the extra vertical space at the top and the rightward bias.
Aligned the highlight more closely with the text to ensure proper visual representation when selecting vertical blocks of text.
Testing:
Verified the fix in various scenarios with vertical, non-English text to confirm that the highlight now aligns correctly without extra spacing.