Add optional parameter antiAliasing and backgroundColor (#54)

* Add optional parameters antiAliasing and backgroundColor * Exclude iOS and Mac Catalyst from MAUI test app * Add expected BackgroundColorTests assets * Optimize TestUtils.CreateOutputStream * Add expected AntiAliasingTests assets
sungaila · Dec 28, 2023 · 41b3524 · 41b3524
1 parent 20b2260
commit 41b3524
Show file tree

Hide file tree

Showing 264 changed files with 3,302 additions and 1,901 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -12,7 +12,7 @@ body:
     attributes:
       label: PDFtoImage version
       description: Which version of PDFtoImage is affected?
-      value: 2.4.3
+      value: 3.0.0
     validations:
       required: true
   - type: dropdown

diff --git a/.github/workflows/githubpages.yml b/.github/workflows/githubpages.yml
@@ -42,7 +42,7 @@ jobs:
       - name: Restore
         run: dotnet restore src/WebConverter/WebConverter.csproj
       - name: Publish
-        run: dotnet publish src/WebConverter/WebConverter.csproj -c Release -p:PublishProfile=src/WebConverter/Properties/PublishProfiles/PublishSite.pubxml --no-restore
+        run: dotnet publish src/WebConverter/WebConverter.csproj -c Release -p:PublishProfile=src/WebConverter/Properties/PublishProfiles/PublishSite.pubxml -p:VersionSuffix=ci --no-restore
       - name: Create .nojekyll file
         run: touch src/WebConverter/bin/Release/net7.0/publish/wwwroot/.nojekyll
       - name: Update service-worker-assets.js hashes
@@ -96,4 +96,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@main
+        uses: actions/deploy-pages@main
diff --git a/.github/workflows/githubpages_staging.yml b/.github/workflows/githubpages_staging.yml
@@ -43,7 +43,7 @@ jobs:
       - name: Restore
         run: dotnet restore src/WebConverter/WebConverter.csproj
       - name: Publish
-        run: dotnet publish src/WebConverter/WebConverter.csproj -c Release -p:PublishProfile=src/WebConverter/Properties/PublishProfiles/PublishSite.pubxml --no-restore
+        run: dotnet publish src/WebConverter/WebConverter.csproj -c Release -p:PublishProfile=src/WebConverter/Properties/PublishProfiles/PublishSite.pubxml -p:VersionSuffix=ci --no-restore
       - name: Create .nojekyll file
         run: touch src/WebConverter/bin/Release/net7.0/publish/wwwroot/.nojekyll
       - name: Update service-worker-assets.js hashes
@@ -99,4 +99,4 @@ jobs:
         id: deployment
         uses: actions/deploy-pages@main
         with:
-          preview: true
+          preview: true
diff --git a/src/Console/Console.csproj b/src/Console/Console.csproj
@@ -7,7 +7,7 @@
     <AssemblyName>PDFtoImage.Console</AssemblyName>
     <RootNamespace>PDFtoImage.Console</RootNamespace>
     <StartupObject>PDFtoImage.Console.Program</StartupObject>
-    <Version>2.4.3</Version>
+    <Version>3.0.0</Version>
     <Configurations>Debug;Release;ReleaseSigned</Configurations>
   </PropertyGroup>
 

diff --git a/src/Console/Program.cs b/src/Console/Program.cs
@@ -4,6 +4,9 @@
 
 namespace PDFtoImage.Console
 {
+#if NET8_0_OR_GREATER
+#pragma warning disable CA1510 // Use ArgumentNullException throw helper
+#endif
     public static class Program
     {
         public static int Main(string[] args)

diff --git a/src/FrameworkTests/AspNetCore/Program.cs b/src/FrameworkTests/AspNetCore/Program.cs
@@ -22,7 +22,9 @@ private static string GetOutput()
             {
                 using var input = new FileStream(Path.Combine(_hostingEnvironment!.WebRootPath, "SocialPreview.pdf"), FileMode.Open, FileAccess.Read);
 
+#pragma warning disable CA1416 // Validate platform compatibility
                 using var bitmap = PDFtoImage.Conversion.ToImage(input);
+#pragma warning restore CA1416 // Validate platform compatibility
 
                 return $"SocialPreview.pdf size: {bitmap.Width}x{bitmap.Height}";
             }

diff --git a/src/FrameworkTests/MauiApp/MainPage.xaml.cs b/src/FrameworkTests/MauiApp/MainPage.xaml.cs
@@ -15,7 +15,9 @@ private async void OnCounterClicked(object sender, EventArgs e)
                 using var ms = new MemoryStream();
                 input.CopyTo(ms);
 
+#pragma warning disable CA1416 // Validate platform compatibility
                 using var bitmap = PDFtoImage.Conversion.ToImage(ms);
+#pragma warning restore CA1416 // Validate platform compatibility
 
                 OutputLabel.Text = $"SocialPreview.pdf size: {bitmap.Width}x{bitmap.Height}";
             }

diff --git a/src/FrameworkTests/MauiApp/MauiApp.csproj b/src/FrameworkTests/MauiApp/MauiApp.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net8.0-android;net8.0-ios;net8.0-maccatalyst</TargetFrameworks>
+    <TargetFrameworks>net8.0-android</TargetFrameworks>
     <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net8.0-windows10.0.19041.0</TargetFrameworks>
     <!-- Uncomment to also build the tizen app. You will need to install tizen by following this: https://github.com/Samsung/Tizen.NET -->
     <!-- <TargetFrameworks>$(TargetFrameworks);net8.0-tizen</TargetFrameworks> -->

diff --git a/src/FrameworkTests/MauiApp/Platforms/Android/MainApplication.cs b/src/FrameworkTests/MauiApp/Platforms/Android/MainApplication.cs
@@ -4,13 +4,8 @@
 namespace PDFtoImage.FrameworkTests.MauiApp
 {
     [Application]
-    public class MainApplication : MauiApplication
+    public class MainApplication(IntPtr handle, JniHandleOwnership ownership) : MauiApplication(handle, ownership)
     {
-        public MainApplication(IntPtr handle, JniHandleOwnership ownership)
-            : base(handle, ownership)
-        {
-        }
-
         protected override Microsoft.Maui.Hosting.MauiApp CreateMauiApp() => MauiProgram.CreateMauiApp();
     }
 }
diff --git a/src/FrameworkTests/MonoAndroid/MonoAndroid.csproj b/src/FrameworkTests/MonoAndroid/MonoAndroid.csproj
@@ -112,9 +112,9 @@
     <Folder Include="Resources\drawable\" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Xamarin.AndroidX.AppCompat" Version="1.6.1.5" />
-    <PackageReference Include="Xamarin.Google.Android.Material" Version="1.10.0.1" />
-    <PackageReference Include="Xamarin.Essentials" Version="1.8.0" />
+    <PackageReference Include="Xamarin.AndroidX.AppCompat" Version="1.6.1.6" />
+    <PackageReference Include="Xamarin.Google.Android.Material" Version="1.10.0.2" />
+    <PackageReference Include="Xamarin.Essentials" Version="1.8.1" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\..\PDFtoImage\PDFtoImage.csproj">