[main] Drop Python 3.8, Increase min deps versions, update tox config on CI, update circleci #636
Conversation
nabobalis
changed the title
nabobalis
changed the title
nabobalis
changed the title
nabobalis
changed the title
| @@ -53,13 +53,13 @@ build-backend = 'setuptools.build_meta' | |||
| enabled = true | |||
|
|
|||
| [ tool.gilesbot.circleci_artifacts.figure_report ] | |||
| url = "py310-figure/figure_test_images/fig_comparison.html" | |||
| message = "Click details to see the figure test comparisons, for figure." | |||
| url = ".tmp/py310-figure/figure_test_images/fig_comparison.html" | |||
There was a problem hiding this comment.
Should these urls really be to .tmp locations?
There was a problem hiding this comment.
it seems to work: https://output.circle-artifacts.com/output/job/cbeb7916-4efd-4249-a92a-4517f00fc7ee/artifacts/0/.tmp/py310-figure/figure_test_images/fig_comparison.html
I forgot why they are moved to .tmp but they seem to be there now.
There was a problem hiding this comment.
They are .tmp so that they don't pollute your local directory if you run this locally.
There was a problem hiding this comment.
That being said, you shouldn't actually need them here. Giles will match on any substring.
|
Looks like the devdeps figtests are still failing, perhaps due to a filepath location issue? |
|
First things last though: Thanks so much @nabobalis for tackling this! |
They are failing from what I understand is that, MPL 3.8.0rc1 is coming out and so the CI picks up this release and therefore does not look for a file with the mpl-dev version but mpl-3.8.0 and therefore fails. I think once MPL 3.8.0 comes out, and they go back to nightly wheels, it should pass again. I don't have a good fix for the rc1 naming issue without maybe a patch to pytest-mpl |
figure devdeps failing due to 3.8.0rc1 and the filename for the hash, is incorrect.