Update error messages for mpl and mpl_animators #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
commented
Nov 15, 2023
| @@ -29,16 +33,20 @@ def _resolve_default_type(self, raise_error=True): | |||
| # delay the import of matplotlib until the plotter is first | |||
| # accessed. | |||
| if self._default_type in ("mpl_plotter", "mpl_sequence_plotter"): | |||
| try: | |||
| if self._default_type == "mpl_plotter": | |||
| if self._default_type == "mpl_plotter": | |||
There was a problem hiding this comment.
This is not a pretty set of blocks.
eteq
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Thanks for the quick work @nabobalis ! I confirm this fixes #650 - both of my concerns there are addressed. One exceedingly minor typo you can accept or not as you prefer.
Co-authored-by: Erik Tollerud <[email protected]>
|
I'll punt the test issue to another future Nabil. |
meeseeksmachine
pushed a commit
to meeseeksmachine/ndcube
that referenced
this pull request
Nov 16, 2023
nabobalis
added a commit
that referenced
this pull request
Nov 16, 2023
…on-2.1 Backport PR #651 on branch 2.1 (Update error messages for mpl and mpl_animators)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #650
TODO: