Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abstract base class for channels #98
Add abstract base class for channels #98
Changes from 25 commits
ac7b5f9
f4b4607
5fc22c1
4f57a1c
75131c8
b52dfb0
64a60fb
9fe1bef
160a9cf
5f4b730
59e7485
919ee62
a63a30a
8366568
b5e5957
4d7f5ba
8f58e56
7fe5238
a415930
50c9776
4c7c5b7
21609b3
fa4dd2e
bcfe9ab
9c02948
c36036a
c329174
1591b8f
be5f3b6
b08d214
5eb3f47
ec03cab
f4696fa
c32a371
6ccd9ef
c73030f
e7b3bc3
8733ba5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 22 in sunkit_instruments/response/thermal.py
sunkit_instruments/response/thermal.py#L22
Check warning on line 88 in sunkit_instruments/response/thermal.py
sunkit_instruments/response/thermal.py#L88
Check warning on line 91 in sunkit_instruments/response/thermal.py
sunkit_instruments/response/thermal.py#L91
Check warning on line 102 in sunkit_instruments/response/thermal.py
sunkit_instruments/response/thermal.py#L101-L102
Check warning on line 104 in sunkit_instruments/response/thermal.py
sunkit_instruments/response/thermal.py#L104
Check warning on line 119 in sunkit_instruments/response/thermal.py
sunkit_instruments/response/thermal.py#L119
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just a general question - could this not be extended for non-imaging instruments? i.e. so not per pixel? how is this planned to deal with these cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great question. I would hope that yes it could be extended to non-imaging instruments as well. What would the units be in that case? Also, do you have an example of a non-imaging instrument that computes a temperature response? Is it common to compute temperature responses for GOES XRS?