-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular fitter attempt #140
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage ? 55.51%
=======================================
Files ? 24
Lines ? 3334
Branches ? 0
=======================================
Hits ? 1851
Misses ? 1483
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@samaloney @KriSun95 @DanRyanIrish @hayesla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
A crack at an updated "modular" fitting interface. Notebook included demonstrating fitting a "line" of "X-ray" data.
No real tests written yet but that's on the agenda, if we want to continue with any of this.
I am curious as to what folks think!
Here's a copy/paste from the "prelude" to that Jupyter notebook:
Modular modeling framework example
This notebook shows how a fitting framework could be made,
in the context of issue #81 and issue #126.
sunkit-spex
has (or will have?) a modular interface.First we define the data interface.
For now it is only X-ray data but we can add more data types.
Then we define the fitting interface.
A
PhotonModel
represents any kind of model which represents photons which get counted.In the future we can add different models, like
IntegratedFluxModels
if theneed arises; there is not a need to tie us to a base class right now.
The first example tackled here is fitting data to a line.$\chi^2$ fitter.
More complex models may be implemented however the user or developers see fit
by modifying the
perform_fit
method in subsequent classes.The first class implemented is a Monte Carlo
A lot of ideas here are similar to pr #130.
I think we should pick and choose what we like from both and move from there.