Skip to content
This repository was archived by the owner on Dec 31, 2022. It is now read-only.

Change into PHP7.4 for mini and make equals strict #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change into PHP7.4 for mini and make equals strict #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## HTTP header kit for PHP 7.1+ compatible with PSR-7, Symfony and Laravel
## HTTP header kit for PHP 7.4+ compatible with PSR-7, Symfony and Laravel

[![Build Status](https://scrutinizer-ci.com/g/sunrise-php/http-header-kit/badges/build.png?b=master)](https://scrutinizer-ci.com/g/sunrise-php/http-header-kit/build-status/master)
[![Code Coverage](https://scrutinizer-ci.com/g/sunrise-php/http-header-kit/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/sunrise-php/http-header-kit/?branch=master)
Expand Down
2 changes: 1 addition & 1 deletion tests/HeaderAccessControlMaxAgeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function testValidValue(int $validValue)
{
$header = new HeaderAccessControlMaxAge($validValue);

$this->assertEquals($validValue, $header->getFieldValue());
$this->assertSame((string) $validValue, $header->getFieldValue());
}

public function validValueDataProvider() : array
Expand Down
2 changes: 1 addition & 1 deletion tests/HeaderAgeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function testValidValue(int $validValue)
{
$header = new HeaderAge($validValue);

$this->assertEquals($validValue, $header->getFieldValue());
$this->assertSame((string) $validValue, $header->getFieldValue());
}

public function validValueDataProvider() : array
Expand Down
6 changes: 3 additions & 3 deletions tests/HeaderCustomTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ public function testFieldName()
{
$header = new HeaderCustom('foo', 'bar');

$this->assertEquals('foo', $header->getFieldName());
$this->assertSame('foo', $header->getFieldName());
}

public function testFieldValue()
{
$header = new HeaderCustom('foo', 'bar');

$this->assertEquals('bar', $header->getFieldValue());
$this->assertSame('bar', $header->getFieldValue());
}

public function testInvalidFieldName()
Expand All @@ -49,7 +49,7 @@ public function testEmptyFieldValue()
{
$header = new HeaderCustom('foo', '');

$this->assertEquals('', $header->getFieldValue());
$this->assertSame('', $header->getFieldValue());
}

public function testInvalidFieldValue()
Expand Down