Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup xml #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cleanup xml #242

wants to merge 2 commits into from

Conversation

nielsbasjes
Copy link
Contributor

This touches only the XML form of the specification and is intended to resolve unclear parts and fix bad xml:

  • All points have an explicit len indicating how many modbus registers must be read.
  • Trivial attributes values that are the same as the default specified in the schema have been removed (like access="r" and mandatory="false")
  • The attribute units="" is meaningless and removed
  • All blocks have an explict type (fixed/repeating)
  • Because I used custom software to do this cleanup all attributes are in the same order everywhere. In fact: I parsed the json and generated the xml from that and then manually cherry picked and verified the changes I'm proposing here.

@cla-bot
Copy link

cla-bot bot commented Dec 31, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @nielsbasjes on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant