model 803 repeated string group count should be top level NStr #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model 803 has a repeated group named
string
, which currently has itscount
attribute incorrectly set to0
within the json specification file.According to the device information model specification, such
count
attribute should be (section 4.1.2):As far as I understand, the current
0
value works withpysunspec2
because of a feature deducing the number of repetitions in the group based on the group length and the parent group lenght.In the case of model 803, the
strings
group will be repeated once per spring, s.t.count
should beNStr
: the number of string in the bank.This PR fixes the model 803 json specification specification, in a similar way as is done in other models (e.g. model 705)