Fix the format of the MAC in model 16 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply changes the specified format of the MAC address in model 16 from an uint64 to eui48.
In my opinion this is a safe change because this does not change the format of the actual bits and/or their interpretation.
The MAC address is still stored in 64 bits (same as the uint64) in the same way and the value for 'unused' is the same as for the uint64 value for 'unused'.
The main reason for this change is that now downstream uses of this specification are better able to understand the way these bits should be interpreted (i.e. the first two bytes are useless).
This fixes #46 and a part of #41