Linkedin OIDC Logo and title in react auth #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? |
J0
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Hey @kieronjmckenna,
Apologies for the delay and thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adding in the linkedin logo and fixing the display name when using the new LinkedIn OIDC provider
What is the current behavior?
Currently it looks like this with the new provider
Which is not ideal
What is the new behavior?
In the react example it now looks like this running in dev:
The same way it looks with the old provider
Additional context
There is an issue filed for this here:
#234
This is my first pull request here, I've tried to follow the guidelines but apologies if I've not stuck to protocol in some way