feat: Button to copy the contents of the Migration tab to the clipboard #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration tab to the clipboard
|
@krisnaw is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
gregnr
reviewed
Sep 27, 2024
Comment on lines
6
to
8
| interface ButtonCopyCodeProps { | ||
| code?: string; | ||
| } |
There was a problem hiding this comment.
A few things:
- Let's make this a type (vs interface) just to be consistent with the other components (and export it)
- Any good reason to make
codeoptional? Probably a clearer contract to make this required, and then upstream components can conditionally render the copy button if the value is optional. - Maybe we just call this
CopyButtonwith avalueprop so that it is more generic and can be used outside code block if we want in the future
| <Button | ||
| variant="outline" | ||
| size="icon" | ||
| className="absolute top-4 right-4 z-10" |
There was a problem hiding this comment.
Let's move layout logic upstream so that this button can be reused more generally.
|
Hi @gregnr, thanks for your feedback! Here are the updates I've made:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces a new Button component that allows users to easily copy the contents of the Migration tab to their clipboard.
What is the current behavior?
Currently, users cannot directly copy the Migration tab's contents.
From this feature request #57
What is the new behavior?
When the button is clicked, its icon will change to a Check icon, indicating that the copy operation has been initiated. Once the copy is complete, the icon will revert to the original Copy icon.
Additional context