fix: assert type in decodeJWTPayload
#1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this PR? This bug is causing issues with my typecheck pipleline |
kangmingtay
approved these changes
Jan 29, 2025
|
closed and reopen to retrigger CI checks 🤷 |
kangmingtay
force-pushed
the
fix-decode-jwt-type
branch
from
42f5b81 to
948a968
Compare
kangmingtay
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Type checking and/or linting does not pass for some configurations, per #967 and #1017
What is the new behavior?
We're now asserting that
parts[1]is a string (aka isn't undefined), since we know from a previous check that the array length is 3.Additional context
Fixes #967 and fixes #1017