Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant getSession type #929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

curiosbasant
Copy link

What kind of change does this PR introduce?

A fix for the getSession return type.

What is the current behavior?

It was difficult to use the following utility function:

async function withThrowOnError<T>(
  promise: Promise<{ data: T; error: null } | { data: unknown; error: Error }>,
): Promise<T> {
  const { data, error } = await promise;
  if (error) throw error;
  return data;
}

withThrowOnError(supabase.auth.getSession()); // Type `null` is not assignable to type `Session`.

What is the new behavior?

It conveniently fixes the type error without breaking anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant