WIP: feat(config): add secrets section to the config #2816
+195
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11890485427Details
💛 - Coveralls |
avallete
changed the title
avallete
force-pushed
the
feat/add-dynamic-env-provider-for-vault
branch
from
3aa1da2
to
b8da16b
Compare
avallete
commented
Oct 31, 2024
avallete
force-pushed
the
feat/add-dynamic-env-provider-for-vault
branch
from
45772ad
to
4e57837
Compare
avallete
changed the title
avallete
changed the title
| @@ -430,6 +441,11 @@ func (c *config) Load(path string, fsys fs.FS) error { | |||
| } else if err := c.loadFromEnv(); err != nil { | |||
| return err | |||
| } | |||
| // Load default secrets build env variables | |||
There was a problem hiding this comment.
We should call this before loadDefaultEnv so that local .env file takes precedence.
| t.Setenv("AUTH_SEND_SMS_SECRETS", "v1,whsec_aWxpa2VzdXBhYmFzZXZlcnltdWNoYW5kaWhvcGV5b3Vkb3Rvbw==") | ||
| t.Setenv("SENDGRID_API_KEY", "sendgrid") | ||
| t.Setenv("AUTH_CALLBACK_URL", "http://localhost:3000/auth/callback") | ||
| assert.NoError(t, config.Load("", fsys)) | ||
| // Check error | ||
| assert.Equal(t, "hello", config.Auth.External["azure"].ClientId) | ||
| assert.Equal(t, "this is cool", config.Auth.External["azure"].Secret) | ||
| assert.Equal(t, "<encrypted-value>", config.Auth.External["azure"].Secret) |
There was a problem hiding this comment.
The previous test should still pass to allow .env.local override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
dynamic_envsection that will be used by branching deploymentWhat is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.