feat: add minimum password length and password requirements config #2885
Conversation
| @@ -18,6 +18,8 @@ type ( | |||
| SiteUrl string `toml:"site_url"` | |||
| AdditionalRedirectUrls []string `toml:"additional_redirect_urls"` | |||
| JwtExpiry uint `toml:"jwt_expiry"` | |||
| MinimumPasswordLength uint `toml:"minimum_password_length"` | |||
| PasswordRequirements string `toml:"password_requirements"` | |||
There was a problem hiding this comment.
Since we started supporting config push command, adding new auth config also requires mapping to the api request / response fields https://github.com/supabase/cli/blob/develop/pkg/config/auth.go#L186.
Once that's mapped, remember to update the diff snapshots in pkg/config/testdata to resolve the failing tests.
There was a problem hiding this comment.
@sweatybridge I think this is going to be an issue for me as I don't know what these keys are on the hosted platform.
There was a problem hiding this comment.
No worries, I can take over from here next week.
Fyi, all fields are more or less documented in the openapi spec.
There was a problem hiding this comment.
I figured it out. The only part is the testdata I'm having trouble with now.
There was a problem hiding this comment.
@sweatybridge Are the diff files manually created or is there a command to run to generate them?
There was a problem hiding this comment.
Deleting a specific diff file in testdata and rerun the corresponding test will regenerate it.
| # Passwords that do not have at least one of each will be rejected as weak. | ||
| # Letters and digits: abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ:0123456789 | ||
| # Lowercase, uppercase letters and digits: abcdefghijklmnopqrstuvwxyz:ABCDEFGHIJKLMNOPQRSTUVWXYZ:0123456789 | ||
| # Lowercase, uppercase letters, digits and symbols: abcdefghijklmnopqrstuvwxyz:ABCDEFGHIJKLMNOPQRSTUVWXYZ:0123456789:!@#$%^&*()_+-=[]{};'\\\\:\"|<>?,./`~ |
There was a problem hiding this comment.
We should make this an enum and validate it, similar to frontend.
| @@ -192,6 +194,8 @@ func (a *auth) ToUpdateAuthConfigBody() v1API.UpdateAuthConfigBody { | |||
| SecurityManualLinkingEnabled: &a.EnableManualLinking, | |||
| DisableSignup: cast.Ptr(!a.EnableSignup), | |||
| ExternalAnonymousUsersEnabled: &a.EnableAnonymousSignIns, | |||
| PasswordMinLength: cast.UintToIntPtr(&a.MinimumPasswordLength), | |||
| PasswordRequiredCharacters: (*v1API.UpdateAuthConfigBodyPasswordRequiredCharacters)(&a.PasswordRequirements), | |||
There was a problem hiding this comment.
Also need to update fromRemoteAuthConfig for the reverse mapping.
What kind of change does this PR introduce?
This feature can be found in the Supabase Hosted Dashboard but doesn't have a way to configure it in the
config.toml.What is the current behavior?
No way to set Password minimum length and Password requirements
What is the new behavior?
Can now set Password minimum length and Password requirements in the
config.tomlfile.Additional context
Add any other context or screenshots.