Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow custom admin and sendername for inbucket #2908

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

avallete
Copy link
Member

What kind of change does this PR introduce?

  • Add sender_name and admin_email for inbucket service configuration

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Related #2899

@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 12008936245

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 59.573%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12005596418: -0.03%
Covered Lines: 6397
Relevant Lines: 10738

💛 - Coveralls

@avallete avallete marked this pull request as ready for review November 25, 2024 11:20
@avallete avallete merged commit c1fb5d0 into develop Nov 25, 2024
9 checks passed
@avallete avallete deleted the feat/allow-custom-admin-inbucket-config branch November 25, 2024 11:32
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants