Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps pgrx to 0.12.4 and adds PG 17 support #57

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

davidgomes
Copy link
Contributor

What kind of change does this PR introduce?

This PR bumps the pgrx version to 0.12.4 so that PG17 can be supported.

What is the new behavior?

$ cargo pgrx run pg16
    Starting Postgres v16 on port 28816
     Creating database pg_jsonschema
psql (16.4)
Type "help" for help.

david@pg_jsonschema=# create extension pg_jsonschema;
CREATE EXTENSION
Time: 252.695 ms
david@pg_jsonschema=# select json_matches_schema('{"type": "object"}', '{}');
┌─────────────────────┐
│ json_matches_schema │
├─────────────────────┤
│ t                   │
└─────────────────────┘
(1 row)

Time: 10.122 ms
david@pg_jsonschema=# ^D\q
$ cargo pgrx run pg17
    Starting Postgres v17 on port 28817
     Creating database pg_jsonschema
psql (17rc1)
Type "help" for help.

david@pg_jsonschema=# create extension pg_jsonschema;
CREATE EXTENSION
Time: 246.665 ms
david@pg_jsonschema=# select json_matches_schema('{"type": "object"}', '{}');
┌─────────────────────┐
│ json_matches_schema │
├─────────────────────┤
│ t                   │
└─────────────────────┘
(1 row)

Time: 9.595 ms
david@pg_jsonschema=# ^D\q

@imor
Copy link
Contributor

imor commented Sep 23, 2024

@davidgomes could you please bump pgrx at these locations as well:

And also rebase on master once this PR is merged.

@davidgomes
Copy link
Contributor Author

@davidgomes could you please bump pgrx at these locations as well:

And also rebase on master once this PR is merged.

Oh, I'm super sorry I totally missed the CI part of this 😞

@olirice olirice self-requested a review September 23, 2024 14:28
dockerfiles/db/Dockerfile Outdated Show resolved Hide resolved
@imor imor merged commit 1093a0b into supabase:master Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants