Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(triggers): list capitalized schema #865

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix(triggers): list capitalized schema #865

merged 2 commits into from
Jan 8, 2025

Conversation

avallete
Copy link
Member

@avallete avallete commented Jan 8, 2025

What kind of change does this PR introduce?

  • Bug fix triggers listing when triggers declared over capitalized schema name
  • Refactor the waiting for the test database to be ready from a sleep 5 to a more reliable healthcheck + --wait docker option.

@avallete
chore(tests): wait until db is ready before running tests
27b52d6
@avallete
fix(triggers): list triggers on captitalized schema namespaces
bd96909 
fix an issue where listing triggers declared over a schema with capitalized name
resulted into an error 3F000
@avallete avallete requested review from a team as code owners January 8, 2025 06:34
@soedirgo soedirgo merged commit fc6120a into master Jan 8, 2025
4 checks passed
@soedirgo soedirgo deleted the fix/triggers-list-captalized-schema branch January 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soedirgo soedirgo soedirgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avallete @soedirgo