feat(typegen): add functions setof type introspection #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introspect the setof function fields for functions - Restore functions as unions of args + returns
avallete
force-pushed
the
feat/add-functions-setof-type-introspection-v2
branch
from
317219e to
64a1afc
Compare
Pull Request Test Coverage Report for Build 18323717185Details
💛 - Coveralls |
avallete
commented
Aug 6, 2025
🚀 Canary Deployment Status✅ Canary image deployed successfully! 🐳 Docker Image: You can test this canary deployment by pulling the image: docker pull supabase/postgres-meta:canary-pr-971-8b65b3904cbc41cd26ea88876ff77d239c70219eYou can also set the version in a supabase local project by running: echo "supabase/postgres-meta:canary-pr-971-8b65b3904cbc41cd26ea88876ff77d239c70219e" > supabase/.temp/pgmeta-versionOr use it in your docker-compose.yml: services:
postgres-meta:
image: supabase/postgres-meta:canary-pr-971-8b65b3904cbc41cd26ea88876ff77d239c70219e
# ... other configurationThe canary image is available on: false Last updated: 2025-10-07T19:34:35Z |
soedirgo
reviewed
Sep 19, 2025
soedirgo
reviewed
Sep 19, 2025
soedirgo
reviewed
Sep 19, 2025
|
Can we split out the refactor into another PR? It's difficult to see which change is related to computed relationships. |
…unctions-setof-type-introspection-v2
avallete
changed the base branch from
master
to
chore/isolate-function-type-generation
…unctions-setof-type-introspection-v2
avallete
added
deploy-canary
avallete
changed the base branch from
chore/isolate-function-type-generation
to
master
avallete
added
deploy-canary
soedirgo
approved these changes
Oct 5, 2025
* fix(typescript): unknown is already nullable Fixes: supabase/cli#4234 supabase/cli#577 * fix: also exclude any from null union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add all the necessary informations for embeded functions type inferences to work in postgrest-js (see: feat(types): add embeded functions type inference postgrest-js#632 )
Canary tested that it's mostly retro-compatible by generating the types on the infrastructure codebase. The new type definition didn't raised much type errors but we don't use a lot of functions/
rpccalls in it. So there is still a chance for this to break some codebases. Best approach might be to release this one as an-rcrelease so it can be opt-in via local cliecho "vXX-rc" > supabase/.temp/postgres-meta-version && supabase gen typesThat way with a canary release of the
postgrest-jsand thesupabase-jswe might release gradually with a way for people to opt-out if it causes issue.I'm open to suggestion about how to release this !
Closes: PGMETA-61