feat: allow injection of httpx client #591
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15581113055Details
💛 - Coveralls |
grdsdev
reviewed
May 10, 2025
postgrest/_async/client.py
Outdated
| ) -> AsyncClient: | ||
| if http_client is not None: | ||
| http_client.base_url = base_url | ||
| http_client.headers = headers |
There was a problem hiding this comment.
should also pass timeout, verify, proxy, here?
There was a problem hiding this comment.
I didn't pass those as I don't want them to be override the options for httpx client the developer will pass. The only options we need to maintain are the base_url and headers. The others should be manually configured by the developer if they are passing their own httpx client.
There was a problem hiding this comment.
got it, let us at least deprecate the usage of the other params in favor of the httpx client as in https://github.com/supabase/functions-py/pull/201/files#r2083278694
|
@silentworks can you add at least one test case that uses a custom httpx instance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Allow developers to supply their own httpx client
What is the current behavior?
Httpx client isn't very configurable and has limited options available for the developer
What is the new behavior?
Httpx client can now be configured by the developer and be supplied to the Postgrest library
Additional context
Add any other context or screenshots.