Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change set auth to sync method #202

Closed
wants to merge 2 commits into from

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix.

What is the current behavior?

set_auth is called async but this won't work when used with supabase-py because the auth change event happens in a sync method.

What is the new behavior?

set_auth is called sync and the auth change event can use the sync method.

Additional context

Add any other context or screenshots.

@J0
Copy link
Collaborator

J0 commented Sep 16, 2024

Hey,

Thanks for PR! Just checking - is this one ready for review?

@silentworks
Copy link
Contributor Author

It is ready for review but I do believe its also a breaking change for anyone using realtime-py as a standalone library. I was going to try another approach of passing a header in like all the other libraries and update that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants