Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return path in the sign-urls endpoint #355

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jul 28, 2023

What kind of change does this PR introduce?

Bug fix,

What is the current behavior?

the path was not returned in the signURLs endpoint

What is the new behavior?

The path is now returned

closes #353

@coveralls
Copy link

coveralls commented Jul 28, 2023

Pull Request Test Coverage Report for Build 5691401355

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.118%

Totals Coverage Status
Change from base Build 5507310300: 0.0%
Covered Lines: 7303
Relevant Lines: 8505

💛 - Coveralls

@fenos fenos merged commit a2371ba into master Jul 28, 2023
1 check passed
@fenos fenos deleted the fix/signedurls-return-path branch July 28, 2023 11:35
@github-actions
Copy link

🎉 This PR is included in version 0.41.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development path is missing when getting signedUrls
3 participants