Skip to content

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Oct 15, 2025

What kind of change does this PR introduce?

Fix

What is the current behavior?

Some issues that needs action from developers are reported using a warning log, which may be lost if a logger isn't attached.

What is the new behavior?

Use IssueReporting lib we already depend on and are using on some places in everywhere the developer is doing something wrong and should action on it.

Additional context

The reportIssue call is no-op in RELEASE builds, but triggers a "purple warning" in Xcode in DEBUG builds, something similar to a breakpoint that doesn't stop execution.

@grdsdev grdsdev requested a review from a team October 15, 2025 18:43
@grdsdev grdsdev force-pushed the guilherme/fix-use-issue-reporting branch from dd3e754 to 6fd537a Compare October 15, 2025 18:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18556248448

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 23 (21.74%) changed or added relevant lines in 2 files are covered.
  • 54 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.9%) to 76.755%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Sources/Realtime/RealtimeChannelV2.swift 2 8 25.0%
Sources/Auth/AuthClient.swift 3 15 20.0%
Files with Coverage Reduction New Missed Lines %
Sources/Helpers/Logger/SupabaseLogger.swift 10 51.55%
Sources/Realtime/RealtimeChannelV2.swift 44 61.91%
Totals Coverage Status
Change from base Build 18526324821: -0.9%
Covered Lines: 5884
Relevant Lines: 7666

💛 - Coveralls

@grdsdev grdsdev force-pushed the guilherme/fix-use-issue-reporting branch from 00c7f35 to 6f14be9 Compare October 16, 2025 09:38
@grdsdev grdsdev merged commit 4ebf243 into main Oct 16, 2025
22 checks passed
@grdsdev grdsdev deleted the guilherme/fix-use-issue-reporting branch October 16, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants